fix(cli): avoid false positive cli upgrade suggestions #12497
Conversation
Skips yanked releases when determining the latest CLI release. This is necessary because we previously released and yanked a 15.0.4 release.
github-actions
bot
added
the
ingestion
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
datahub-cyborg
bot
added
the
needs-review
After reviewing some of the yanked versions in https://pypi.org/pypi/acryl_datahub/json, wondering why not removing some of them such as 15.0.4? |
datahub-cyborg
bot
added
pending-submitter-response
| filtered_releases = { | ||
| version: release_files | ||
| for version, release_files in releases.items() | ||
| if not all( |
There was a problem hiding this comment.
not all or not any ? 🤔
There was a problem hiding this comment.
We have two files per release - a .tar.gz and .whl file. If in the future we add architecture-specific .whl files, we'll have multiple. We should only really consider a release yanked if every file is yanked - if we yank only a specific file due to a packaging issue, the release is still mostly valid
datahub-cyborg
bot
added
pending-submitter-merge
and removed
pending-submitter-response
Skips yanked releases when determining the latest CLI release. This is necessary because we previously released and yanked a 15.0.4 release.
Checklist